Change in osmo-bts[master]: lchan_set_state(): also free pending messages if any

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25905 )

Change subject: lchan_set_state(): also free pending messages if any
......................................................................

lchan_set_state(): also free pending messages if any

A logical channel may have associated messages, which are pending
for transmission until some event occurs.  Do not leak them.

Change-Id: I3264e6caa007e9e9cb9c1c2f8627c408bbb28b9e
---
M src/common/lchan.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/common/lchan.c b/src/common/lchan.c
index 9f27409..c2b0144 100644
--- a/src/common/lchan.c
+++ b/src/common/lchan.c
@@ -298,6 +298,11 @@
 		lchan->rep_acch.dl_facch[1].msg = NULL;
 		msgb_free(lchan->rep_acch.dl_sacch_msg);
 		lchan->rep_acch.dl_sacch_msg = NULL;
+		/* free() pending messages */
+		msgb_free(lchan->pending_rel_ind_msg);
+		lchan->pending_rel_ind_msg = NULL;
+		msgb_free(lchan->pending_chan_activ);
+		lchan->pending_chan_activ = NULL;
 		/* fall through */
 	default:
 		if (lchan->early_rr_ia) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25905
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3264e6caa007e9e9cb9c1c2f8627c408bbb28b9e
Gerrit-Change-Number: 25905
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211024/1a012274/attachment.htm>