Change in osmo-bts[master]: measurement: handle_ms_meas_report() accepts const gh

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Oct 22 13:54:24 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25891 )

Change subject: measurement: handle_ms_meas_report() accepts const gh
......................................................................

measurement: handle_ms_meas_report() accepts const gh

Change-Id: Iba37c1a92b8b17a8ba8c958fb6c296747578cb1b
---
M include/osmo-bts/measurement.h
M src/common/measurement.c
2 files changed, 8 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/include/osmo-bts/measurement.h b/include/osmo-bts/measurement.h
index 481b7be..f63a05a 100644
--- a/include/osmo-bts/measurement.h
+++ b/include/osmo-bts/measurement.h
@@ -20,6 +20,8 @@
 
 int is_meas_complete(struct gsm_lchan *lchan, uint32_t fn);
 
-int handle_ms_meas_report(struct gsm_lchan *lchan, struct gsm48_hdr *gh, unsigned int len);
+int handle_ms_meas_report(struct gsm_lchan *lchan,
+			  const struct gsm48_hdr *gh,
+			  unsigned int len);
 
 #endif
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 87e853e..0a8a182 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -791,7 +791,9 @@
 
 /* Called every time a Measurement Result (TS 08.58 8.4.8) is received from
  * lower layers and has to be forwarded to BSC */
-int handle_ms_meas_report(struct gsm_lchan *lchan, struct gsm48_hdr *gh, unsigned int len)
+int handle_ms_meas_report(struct gsm_lchan *lchan,
+			  const struct gsm48_hdr *gh,
+			  unsigned int len)
 {
 	int timing_offset, rc;
 	struct lapdm_entity *le;
@@ -804,7 +806,7 @@
 	le = &lchan->lapdm_ch.lapdm_acch;
 
 	timing_offset = ms_to_valid(lchan) ? ms_to2rsl(lchan, le) : -1;
-	rc = rsl_tx_meas_res(lchan, (uint8_t *)gh, len, timing_offset);
+	rc = rsl_tx_meas_res(lchan, (const uint8_t *)gh, len, timing_offset);
 	if (rc == 0) /* Count successful transmissions */
 		lchan->meas.res_nr++;
 
@@ -849,7 +851,7 @@
 	lchan_ms_ta_ctrl(lchan, ms_ta, lchan->meas.ms_toa256);
 	lchan_ms_pwr_ctrl(lchan, ms_pwr, ul_rssi, ul_ci_cb);
 	if (gh)
-		lchan_bs_pwr_ctrl(lchan, (const struct gsm48_hdr *) gh);
+		lchan_bs_pwr_ctrl(lchan, gh);
 
 	/* Reset state for next iteration */
 	lchan->tch.dtx.dl_active = false;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25891
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iba37c1a92b8b17a8ba8c958fb6c296747578cb1b
Gerrit-Change-Number: 25891
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211022/1e0da67f/attachment.htm>


More information about the gerrit-log mailing list