Change in libosmocore[master]: gsm_08_58: extend struct abis_rsl_osmo_temp_ovp_acch_cap

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Oct 21 18:04:26 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25866 )

Change subject: gsm_08_58: extend struct abis_rsl_osmo_temp_ovp_acch_cap
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/25866/1/include/osmocom/gsm/protocol/gsm_08_58.h 
File include/osmocom/gsm/protocol/gsm_08_58.h:

https://gerrit.osmocom.org/c/libosmocore/+/25866/1/include/osmocom/gsm/protocol/gsm_08_58.h@145 
PS1, Line 145: 	uint8_t sacch:1,
> I'd rename those to sacch_enabled and alike, otherwise it's confusing imho.
ACK, I was thinking about adding _enable too.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25866
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia28293a12de0af71f55e701fb65c46e905dae217
Gerrit-Change-Number: 25866
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Oct 2021 18:04:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211021/0287fd79/attachment.htm>


More information about the gerrit-log mailing list