Change in osmo-ttcn3-hacks[master]: BSC_Tests: set band in f_TC_fh_params_set

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 )

Change subject: BSC_Tests: set band in f_TC_fh_params_set
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

Looks good to me, and even better than my patch #25824 because it's a more fundamental approach that would allow us to verify handling of ARFCNs belonging to PCS-1900. Just a few rather cosmetic things...

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/2/bsc/BSC_Tests.ttcn 
File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/2/bsc/BSC_Tests.ttcn@8502 
PS2, Line 8502: 	if (arfcn.arfcn >= 259 and arfcn.arfcn <= 293) {
> iirc ttcn3 has specific syntax to match ranges, @fixeria may remember better the details.
Yep, you could use 'select' here:

  select (arfcn) {
  case (tr_GsmBandArfcn(306 .. 340)) { band := "GSM450"; }
  case (tr_GsmBandArfcn(438 .. 511)) { band := "GSM480"; }
  /* ... */
  case (tr_GsmBandArfcn(512 .. 885, pcs := false)) { band := "DCS1800"; }
  case (tr_GsmBandArfcn(512 .. 810, pcs := true))  { band := "PCS1900"; }
  case else { return; }
  }


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/2/bsc/BSC_Tests.ttcn@8524 
PS2, Line 8524: 	f_vty_transceive(BSCVTY, "exit");
Just send 'end' command once instead of sending 'exit' three times.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647
Gerrit-Change-Number: 25828
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Oct 2021 21:49:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211019/41dc379d/attachment.htm>