Change in libosmocore[master]: ns2: ensure the NSVC is in the correct mode for NSVC UNKNOWN/NSVC BLO...

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25555 )

Change subject: ns2: ensure the NSVC is in the correct mode for NSVC UNKNOWN/NSVC BLOCKED cause codes
......................................................................

ns2: ensure the NSVC is in the correct mode for NSVC UNKNOWN/NSVC BLOCKED cause codes

Those cause codes are only valid for BLOCK/RESET NSVCs.

Change-Id: I560f1c8c2826befd03641bebffe156ac070061c2
---
M src/gb/gprs_ns2_message.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_ns2_message.c b/src/gb/gprs_ns2_message.c
index 90873ed..de30470 100644
--- a/src/gb/gprs_ns2_message.c
+++ b/src/gb/gprs_ns2_message.c
@@ -103,6 +103,11 @@
 			*cause = NS_CAUSE_MISSING_ESSENT_IE;
 			return -1;
 		}
+
+		if (nsvc->mode != GPRS_NS2_VC_MODE_BLOCKRESET) {
+			*cause = NS_CAUSE_PDU_INCOMP_PSTATE;
+			return -1;
+		}
 		break;
 	case NS_CAUSE_SEM_INCORR_PDU:
 	case NS_CAUSE_PDU_INCOMP_PSTATE:

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25555
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I560f1c8c2826befd03641bebffe156ac070061c2
Gerrit-Change-Number: 25555
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211008/43d04af5/attachment.htm>