Change in pysim[master]: pySim-shell: allow card insertion at runtime

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25549 )

Change subject: pySim-shell: allow card insertion at runtime
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/25549/3/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/25549/3/pySim-shell.py@127 
PS3, Line 127: 		if (cmd_set != []):
A more elegant solution would be:

  if not cmd_set:
    self.unregister_command_set(cmd_set[0])

Not critical though.


https://gerrit.osmocom.org/c/pysim/+/25549/3/pySim-shell.py@130 
PS3, Line 130: 		if (cmd_set != []):
Same here. See https://stackoverflow.com/questions/53513/how-do-i-check-if-a-list-is-empty.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/25549
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9cf532d9da8203065463c7201e7064de6c7ab1b5
Gerrit-Change-Number: 25549
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Oct 2021 10:45:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211007/7a0f6945/attachment.htm>