Change in osmo-bsc[master]: tsc fixup: tweak condition for coverity

[neels]

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25684 )

Change subject: tsc fixup: tweak condition for coverity
......................................................................

tsc fixup: tweak condition for coverity

Related: CID#240352 SYS#4895
Change-Id: Idbc6b47df0aeca9b6d870386b037dd6fb7c96c82
---
M src/osmo-bsc/assignment_fsm.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  neels: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index a1b423f..1449bdb 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -836,13 +836,14 @@
 		.ch_mode_rate = conn->assignment.selected_ch_mode_rate,
 		.requires_voice_stream = conn->assignment.requires_voice_stream,
 		.msc_assigned_cic = req->msc_assigned_cic,
-		/* keep previous training sequence code */
+		/* keep previous training sequence code. TSC is always present, TSC Set may or may not be an explicit
+		 * value. */
 		.tsc_set = {
 			.present = (lchan->tsc_set >= 0),
 			.val = lchan->tsc_set,
 		},
 		.tsc = {
-			.present = (lchan->tsc >= 0),
+			.present = true,
 			.val = lchan->tsc,
 		},
 	};

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25684
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idbc6b47df0aeca9b6d870386b037dd6fb7c96c82
Gerrit-Change-Number: 25684
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211005/03f83196/attachment.htm>