Change in libosmocore[master]: gsmtap: allow 127.0.0.x local listeners

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Mon Oct 4 14:05:39 UTC 2021


Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25622 )

Change subject: gsmtap: allow 127.0.0.x local listeners
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/25622/1/src/socket.c 
File src/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/25622/1/src/socket.c@1141 
PS1, Line 1141: 	uint32_t address = ((struct sockaddr_in *)a)->sin_addr.s_addr; /* already BE */
> what about ipv6?
no, see the check above


https://gerrit.osmocom.org/c/libosmocore/+/25622/1/src/socket.c@1160 
PS1, Line 1160: 	if (sockaddr_is_local_routed(addr))
> IIRC the 127.0.0. […]
the function itself does all the work including the check, as it should.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25622
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1043dfd8075f14481011f43db45c943e9320413c
Gerrit-Change-Number: 25622
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Oct 2021 14:05:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211004/87a90076/attachment.htm>


More information about the gerrit-log mailing list