Change in osmo-ggsn[master]: Introduce program gtp-echo-responder

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/25652 )

Change subject: Introduce program gtp-echo-responder
......................................................................


Patch Set 6:

(8 comments)

https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c 
File utils/gtp_echo_responder.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c@109 
PS6, Line 109: 	       "  -l --listen-addr	Listend address for GTPCv1 and GTPCv2\n"
"Listen" (typo). ... or maybe "Address to listen on for ..."


https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c@128 
PS6, Line 128: 	    arg == end) {
if arg should not contain trailing characters after the bitmask, you should also add '|| *end', i.e. if the endptr has more characters after conversion


https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c@151 
PS6, Line 151: d
'-d' seems nonexistent


https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c@169 
PS6, Line 169: 			g_st->cfg.recovery_ctr = (uint8_t)atoi(optarg);
break (or "/* fall thru */")


https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c@190 
PS6, Line 190: 
(usually we'd not have a blank line here)


https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c@225 
PS6, Line 225: 			strcpy(_rem_addr_str, "unknwown");
typo "unknwown" x 3


https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c@248 
PS6, Line 248: 		fprintf(stderr, "sendto() short write: %u vs exp %u\n", rc, buf_len);
size_t should be indicated as %zu, the compiler should complain about this
... not sure about ssize_t, %zd??


https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c@281 
PS6, Line 281: 	/* TS 29.274 sec 8.5 Recovery (Restart Counter) */
(we usually add "3GPP" before "TS")



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/25652
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Ibdd6d8f6920571db0c60cf8b3b25d541b15ad3f1
Gerrit-Change-Number: 25652
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Oct 2021 11:53:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211004/32a6c69a/attachment.htm>