Change in pysim[master]: pySim-shell: allow card insertion at runtime

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25549 )

Change subject: pySim-shell: allow card insertion at runtime
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/pysim/+/25549/2/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/25549/2/pySim-shell.py@96 
PS2, Line 96: 		basic_commands = []
> this variable can be removed
Done


https://gerrit.osmocom.org/c/pysim/+/25549/2/pySim-shell.py@106 
PS2, Line 106: 		self.add_settable(cmd2.Settable('numeric_path', bool, 'Print File IDs instead of names',
> looks like unrelated moving around of variables, -> extra commit?
Done


https://gerrit.osmocom.org/c/pysim/+/25549/2/pySim-shell.py@587 
PS2, Line 587: execption
> exception
Thanks!



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/25549
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9cf532d9da8203065463c7201e7064de6c7ab1b5
Gerrit-Change-Number: 25549
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 01 Oct 2021 16:12:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211001/9e957567/attachment.htm>