Change in osmo-bsc[master]: Implement MS Uplink Power Control Loop.

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25654 )

Change subject: Implement MS Uplink Power Control Loop.
......................................................................


Patch Set 7:

(8 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/include/osmocom/bsc/gsm_data.h 
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/include/osmocom/bsc/gsm_data.h@825 
PS7, Line 825: 	struct gsm_power_ctrl_meas_proc_state rxlev_meas_proc;
> Put this inside a struct lchan_power_ctrl_state {} similar to what's done in osmo-bts. […]
Ack


https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/src/osmo-bsc/bsc_vty.c@1359 
PS7, Line 1359: == GSM_PWR_CTRL_MODE_DYN_BSC
I would rather do != GSM_PWR_CTRL_MODE_DYN_BTS here. But first would be good to know why are you adding this check here?


https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/src/osmo-bsc/bts_vty.c 
File src/osmo-bsc/bts_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/src/osmo-bsc/bts_vty.c@3150 
PS7, Line 3150: 	if (params->mode == GSM_PWR_CTRL_MODE_DYN_BSC) {
These thresholds also does not matter in 'static' mode. Not sure if we really need this check here...


https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/src/osmo-bsc/power_control.c 
File src/osmo-bsc/power_control.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/src/osmo-bsc/power_control.c@161 
PS7, Line 161: struct gsm_meas_rep *mr
Please make this pointer 'const'.


https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/src/osmo-bsc/power_control.c@170 
PS7, Line 170: 	// int16_t ul_lqual_cb_avg;
> can be dropped
Ack


https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/src/osmo-bsc/power_control.c@177 
PS7, Line 177: 	/* Not doing the power loop here if we are not handling it */
I would move this check to the calling function, but not critical.


https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/src/osmo-bsc/power_control.c@183 
PS7, Line 183: 	if (bts->dtxu == GSM48_DTX_SHALL_BE_USED)
> IIRC this can be obtained from the MR? it depends on the channel.
Indeed. I guess 'mr->flags & MEAS_REP_F_UL_DTX'?


https://gerrit.osmocom.org/c/osmo-bsc/+/25654/7/src/osmo-bsc/power_control.c@188 
PS7, Line 188: 	/* Shall we skip current block based on configured interval? */
> Let's move this further up before the dtxu block.
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25654
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibc307e758697eb5ca3fb86622f35709d6077db9e
Gerrit-Change-Number: 25654
Gerrit-PatchSet: 7
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 01 Oct 2021 10:08:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211001/ee2e9a45/attachment.htm>