Change in osmo-msc[master]: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu()

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26411 )


Change subject: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu()
......................................................................

libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu()

If a MO SMS gets successfully routed through SMPP, we return early
in gsm340_rx_tpdu() and leak a chunk of type 'struct gsm_sms'.

Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228
Fixes: [1] Ic34d398e0a850856e20380ae35e5c2ae5e3c539b
Fixes: OS#5334
---
M src/libmsc/gsm_04_11.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/26411/1

diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c
index 199fdc1..bd7cf1f 100644
--- a/src/libmsc/gsm_04_11.c
+++ b/src/libmsc/gsm_04_11.c
@@ -631,7 +631,8 @@
 
 	/* This SMS got routed through SMPP and we are waiting on the response. */
 	if (gsms->smpp.esme) {
-		return -EINPROGRESS;
+		rc = -EINPROGRESS;
+		goto out;
 	}
 
 	/* This SMS got routed through SMPP, but the configured ESME was

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228
Gerrit-Change-Number: 26411
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211128/3229ea5f/attachment.htm>