Change in osmo-msc[master]: msc: always require ciphering for UTRAN

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26390 )


Change subject: msc: always require ciphering for UTRAN
......................................................................

msc: always require ciphering for UTRAN

OsmoMSC treats UTRAN SecurityCommand as ciphering and UTRAN requires
the SecurityCommand even when not requiring any encryption.

Fixes: 505a94a610fc ("Make UTRAN encryption algorithms configurable")
Change-Id: I8896ecc2f23c8fdb2b3e83b3aeabd55a0911a612
---
M src/libmsc/msc_a.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/90/26390/1

diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c
index cb7566a..424248a 100644
--- a/src/libmsc/msc_a.c
+++ b/src/libmsc/msc_a.c
@@ -109,8 +109,10 @@
 bool msc_a_require_ciphering(const struct msc_a *msc_a) {
 	struct gsm_network *net = msc_a_net(msc_a);
 	bool is_utran = (msc_a->c.ran->type == OSMO_RAT_UTRAN_IU);
+	/* UTRAN requires a SecurityCommand which OsmoMSC treats as Ciphering.
+	 * Depending on the uea_encryption_mask there might be no encryption. */
 	if (is_utran)
-		return net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0);
+		return true;
 	else
 		return net->a5_encryption_mask > 0x1;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26390
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8896ecc2f23c8fdb2b3e83b3aeabd55a0911a612
Gerrit-Change-Number: 26390
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211127/6528e04d/attachment.htm>