Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Nov 23 17:41:19 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 )

Change subject: pySim-read: put try/catch block around select_adf_by_aid()
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/26253/5/pySim-read.py 
File pySim-read.py:

https://gerrit.osmocom.org/c/pysim/+/26253/5/pySim-read.py@48 
PS5, Line 48: def select_app(adf:str):
> method on card class likely makes even more sense, yes.
I don't get why this even works without card as parameter. This is now fixed.

I won't put this into the card class, the card class is already a kitchen sink for a lot of stuff. Also this function contains print statements which are tuned to this program.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/26253
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef
Gerrit-Change-Number: 26253
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Nov 2021 17:41:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211123/f830dba1/attachment.htm>


More information about the gerrit-log mailing list