This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 ) Change subject: gbproxy: Also try to route STATUS messages with truncated PDU in error ...................................................................... Patch Set 2: (2 comments) > Patch Set 1: > Does this really make sense? expecting this kind of issue and forwarding. Well, we specified doing this from the start. Truncated pdu-in-error can happen if the original pdu was close to the MTU already (e.g. unitdata, RIM messages). Since the BVC is established end-to-end we need to route the STATUS correctly so the offending side can take action and/or report the issue. https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319/1/src/gb_proxy.c File src/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319/1/src/gb_proxy.c@986 PS1, Line 986: /* Ignore decode failure, due to trucated message */ > truncated. And the comma can be removed imho. Ack https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319/1/src/gb_proxy.c@1014 PS1, Line 1014: /* Ignore decode failure, due to trucated message */ > same Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 Gerrit-Change-Number: 26319 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 18 Nov 2021 15:23:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211118/64d33bda/attachment.htm>