This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26309 ) Change subject: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26309/1/src/bitvec.c File src/bitvec.c: https://gerrit.osmocom.org/c/libosmocore/+/26309/1/src/bitvec.c@497 PS1, Line 497: if (bv->data[bytenum] & (1 << bitnum)) > Are you sure this is going to work? The 'bit' must be either 0 or 1, like the value returned by bitv […] Ah good point. You'd need to do the following to convert it to 0/1: bit = !!(bv->data[bytenum] & (1 << bitnum)); It was just an idea, no need for you to implement it if you don't want. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I438fc82d33ab2edbabd4215ec7bc46afb07d50ab Gerrit-Change-Number: 26309 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 17 Nov 2021 15:19:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211117/25ca3ba1/attachment.htm>