Change in pysim[master]: pySim-shell: add method to match card profile to card

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 )

Change subject: pySim-shell: add method to match card profile to card
......................................................................


Patch Set 6:

(3 comments)

The patch looks a lot better now, thanks! Just a few minor things...

https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/profile.py 
File pySim/profile.py:

https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/profile.py@52 
PS6, Line 52: match_sim
I still don't like this code duplication. Both functions are basically doing the same thing: trying to select '3f00' using the given CLA/SEL bytes. I suggest to add a more generic method to CardProfile and call it e.g. try_select_3f00() or so. Then in child classes you could use it this way:

  if self.try_select_3f00(): # will use self.cla and self.sel_ctrl

or even this way in CardProfileUICCSIM:

  if self.try_select_3f00() and self.try_select_3f00(sel_ctrl='0000'):


https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/profile.py@154 
PS6, Line 154: key=operator.attrgetter('order')
Alternatively: key=lambda cls: cls.order


https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/ts_102_221.py 
File pySim/ts_102_221.py:

https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/ts_102_221.py@615 
PS6, Line 615: order
Cosmetic: class properties are usually upper case.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/26165
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691
Gerrit-Change-Number: 26165
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Nov 2021 17:38:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211116/237fa4ba/attachment.htm>