Change in osmo-msc[master]: Do not mention deprecated -M / --mncc-sock-path options

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26224 )

Change subject: Do not mention deprecated -M / --mncc-sock-path options
......................................................................

Do not mention deprecated -M / --mncc-sock-path options

Change-Id: I34387f561446aa5bf5db5264f0aca6bf6469d0e5
---
M doc/manuals/chapters/running.adoc
M src/osmo-msc/msc_main.c
2 files changed, 4 insertions(+), 8 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc
index 445a164..988b84d 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -5,7 +5,7 @@
 
 === SYNOPSIS
 
-*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE'] [-M 'SOCKETPATH']
+*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE']
 
 === OPTIONS
 
@@ -37,11 +37,6 @@
 	<<logging>> for more information.
 *-l, --database 'DATABASE'*::
 	Specify the file name of the SQLite3 database to use as SMS storage
-*-M, --mncc-sock-path*::
-	Enable the MNCC socket for an external MNCC handler. See
-	<<mncc>> for further information.
-*-m, --mncc-sock*::
-	Same as option -M (deprecated).
 
 
 === Multiple instances
diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index cd91d54..07d76dd 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -131,7 +131,6 @@
 	printf("  -T --timestamp             Prefix every log line with a timestamp.\n");
 	printf("  -V --version               Print the version of OsmoMSC.\n");
 	printf("  -e --log-level number      Set a global loglevel.\n");
-	printf("  -M --mncc-sock-path PATH   Disable built-in MNCC handler and offer socket.\n");
 
 	printf("\nVTY reference generation:\n");
 	printf("     --vty-ref-mode MODE     VTY reference generation mode (e.g. 'expert').\n");
@@ -178,7 +177,7 @@
 			{"timestamp", 0, 0, 'T'},
 			{"version", 0, 0, 'V' },
 			{"log-level", 1, 0, 'e'},
-			{"mncc-sock-path", 1, 0, 'M'},
+			{"mncc-sock-path", 1, 0, 'M'}, /* deprecated */
 			{"no-dbcounter", 0, 0, 'C'}, /* deprecated */
 			{"vty-ref-mode", 1, &long_option, 1},
 			{"vty-ref-xml", 0, &long_option, 2},
@@ -221,6 +220,8 @@
 			break;
 		case 'M':
 			msc_cmdline_config.mncc_sock_path = optarg;
+			fprintf(stderr, "Command line argument '-%c' is deprecated, use VTY "
+				"parameter 'msc' / 'mncc external %s' instead.\n", c, optarg);
 			break;
 		case 'C':
 			fprintf(stderr, "-C is deprecated and does nothing.");

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26224
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I34387f561446aa5bf5db5264f0aca6bf6469d0e5
Gerrit-Change-Number: 26224
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211112/f9fce682/attachment.htm>