Change in osmo-pcu[master]: tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26208 )

Change subject: tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent
......................................................................

tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent

If by the time the PktDlAss is to be scheduled by the scheduler the DL
TBF is gone, the FSM will abort the assignment and go back to state
NONE.
However, the transition was missing, ending up in the scheduler trying
to schedule the message unsuccessfuly lots of times per second, clogging
the logs and disrupting normal operation.

Related: OS#5293
Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647
---
M src/tbf_dl_ass_fsm.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  daniel: Looks good to me, approved
  keith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c
index efc872a..555380d 100644
--- a/src/tbf_dl_ass_fsm.c
+++ b/src/tbf_dl_ass_fsm.c
@@ -208,7 +208,9 @@
 	},
 	[TBF_DL_ASS_SEND_ASS] = {
 		.in_event_mask = X(TBF_DL_ASS_EV_CREATE_RLCMAC_MSG),
-		.out_state_mask = X(TBF_DL_ASS_WAIT_ACK),
+		.out_state_mask =
+			X(TBF_DL_ASS_WAIT_ACK) |
+			X(TBF_DL_ASS_NONE),
 		.name = "SEND_ASS",
 		.action = st_send_ass,
 	},

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26208
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647
Gerrit-Change-Number: 26208
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211112/3da53629/attachment.htm>