Change in osmo-mgw[master]: add a lock-free bounded spsc interthread queue

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Nov 10 12:41:18 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25431 )

Change subject: add a lock-free bounded spsc interthread queue
......................................................................


Patch Set 21:

(3 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/include/osmocom/mgcp/mgcp_threads_queue.h 
File include/osmocom/mgcp/mgcp_threads_queue.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/include/osmocom/mgcp/mgcp_threads_queue.h@27 
PS21, Line 27: 	atomic_uint readptr;
I'd welcome some brief documentation for each of the fields, it's not like it's a simple data structure+algo...


https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/include/osmocom/mgcp/mgcp_threads_queue.h@46 
PS21, Line 46: ssize_t prep_pop(struct spsc *q);
probably worth adding a spsc_* prefix to all functions listed here.


https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/src/libosmo-mgcp/mgcp_threads_queue.c 
File src/libosmo-mgcp/mgcp_threads_queue.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/src/libosmo-mgcp/mgcp_threads_queue.c@38 
PS21, Line 38: -> own ptr relaxed, other one not so much...
what do you mean here?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657
Gerrit-Change-Number: 25431
Gerrit-PatchSet: 21
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Nov 2021 12:41:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211110/c2d5891e/attachment.htm>


More information about the gerrit-log mailing list