This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: (1 comment) (sorry, should have reviewed a lot sooner) https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c@216 PS3, Line 216: lchan = &ts->lchan[i]; For dyn TS in TCH mode, the primary lchans are each shadowed by a VAMOS lchan (1 VAMOS for TCH/F, 2 VAMOS for TCH/H). For SDCCH8, there should be no VAMOS secondary at all. But for SDCCH8, ts->max_primary_lchans should be 8, and ts->max_lchans_possible should also be 8. So I wonder why this extra condition is needed at all? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Tue, 09 Nov 2021 08:03:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211109/9ae04dc3/attachment.htm>