Change in osmo-bsc[master]: refactor lchan counting

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 )

Change subject: refactor lchan counting
......................................................................


Patch Set 3:

(2 comments)

Just now I am busy implementing with a struct, but I am having the problem of ... (s.b.)

https://gerrit.osmocom.org/c/osmo-bsc/+/25972/3/src/osmo-bsc/chan_counts.c 
File src/osmo-bsc/chan_counts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25972/3/src/osmo-bsc/chan_counts.c@29 
PS3, Line 29: 
...adding this array...


https://gerrit.osmocom.org/c/osmo-bsc/+/25972/3/src/osmo-bsc/chan_counts.c@81 
PS3, Line 81: 		chan_counts_dim3_add(ts_count[CHAN_COUNTS2_MAX_TOTAL], lchans_per_pchan[ts->pchan_on_init]);
...to this

Because with a struct, it looks like this:

 static inline void chan_counts_dim3_add(struct chan_counts *dst, const struct chan_counts *add,
                                         enum chan_counts_dim1 dim1, enum chan_counts_dim2 dim2)
 {               
         int i;  
         for (i = 0; i < _GSM_LCHAN_MAX; i++)
                  dst->val[dim1][dim2][i] += add->val[dim1][dim2][i];
 } 

So the array to be added is also a struct chan_counts, but above struct lchans_per_pchan has a quite different structure. Only that struct's second dimension is the same as chan_counts' third dimension ... don't know how to resolve that now



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3
Gerrit-Change-Number: 25972
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 06 Nov 2021 16:49:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211106/cd817fd4/attachment.htm>