Change in pysim[master]: pySim-shell: add method to probe for UICC

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Fri Nov 5 12:34:47 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26043 )

Change subject: pySim-shell: add method to probe for UICC
......................................................................


Patch Set 4:

(1 comment)

(clicking on start review to add a comment)

https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py@85 
PS4, Line 85: ;
> Thanks! There is no way to have this in the linter? python does not complain about it, so this goes  […]
you can install flake8 and put something like this in your pre-commit hook:

  flake8 --select E703 $(find -name '*.py')

it will test for this, e.g.:
  ./test.py:15:74: E703 statement ends with a semicolon


to add it to the linter that runs in gerrit, I've created: https://osmocom.org/issues/5292



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/26043
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605
Gerrit-Change-Number: 26043
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Nov 2021 12:34:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211105/8d637f4a/attachment.htm>


More information about the gerrit-log mailing list