Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Nov 4 16:56:36 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26055 )

Change subject: commands: do not check SW manually, use send_apdu_checksw()
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py 
File pySim/commands.py:

https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py@148 
PS2, Line 148: 			data, sw = self._tp.send_apdu_checksw(pdu)
> side note: I think if the export command relies on no CR/LF in an exception text, then it should its […]
Are multi line exception strings even possible? I don't know, I have never seen any.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/26055
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79
Gerrit-Change-Number: 26055
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Nov 2021 16:56:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211104/bf410cd2/attachment.htm>


More information about the gerrit-log mailing list