Change in osmo-bts[master]: lchan_meas_handle_sacch(): check if Measurement Result is valid

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26047 )

Change subject: lchan_meas_handle_sacch(): check if Measurement Result is valid
......................................................................

lchan_meas_handle_sacch(): check if Measurement Result is valid

We should not rely on measurement data marked as invalid.

Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2
---
M src/common/measurement.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve



diff --git a/src/common/measurement.c b/src/common/measurement.c
index 3aeb901..73c5e43 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -951,7 +951,8 @@
 	 */
 	if (gh && gh->msg_type == GSM48_MT_RR_MEAS_REP) {
 		mr = (const struct gsm48_meas_res *)gh->data;
-		dtxu_used = mr->dtx_used;
+		if (mr->meas_valid == 0) /* 0 = valid */
+			dtxu_used = mr->dtx_used;
 	}
 
 	if (dtxu_used) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26047
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2
Gerrit-Change-Number: 26047
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211104/3231b27d/attachment.htm>