This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26068 )
Change subject: add chreq:successful_<reason> rate counters
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c@2155
PS1, Line 2155: switch (lchan->activate.info.chreq_reason) {
Just raising the topic: I often have the feeling these long chunks of code affect readability of the usual flow of the code. I'd argue it be far more clean to wrap all this into 1 function lchan_rate_ctr_inc(lchan) and move it somewhere else (lchan.c?) Because usually nobody cares about this when reading the code.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62
Gerrit-Change-Number: 26068
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Nov 2021 18:04:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211102/b5d3ffce/attachment.htm>