Change in osmo-mgw[master]: mgcp_network: refactor MGCP_DUMMY_LOAD

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun May 30 09:20:23 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24315 )

Change subject: mgcp_network: refactor MGCP_DUMMY_LOAD
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/24315/2/include/osmocom/mgcp/mgcp_network.h 
File include/osmocom/mgcp/mgcp_network.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/24315/2/include/osmocom/mgcp/mgcp_network.h@19 
PS2, Line 19: 	 memcmp(msgb_data(msg), rtp_dummy_payload, sizeof(rtp_dummy_payload)) == 0))
> when rtp_dummy_load is only one byte the compiler should optimize out the memcmp(). […]
how many hundreds of thousands of time are we executing this per second to care about optimizing away a memcmp?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24315
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I21d96cefeeb647958bfa1e22a0ea030884746fad
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Sun, 30 May 2021 09:20:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210530/68114605/attachment.htm>


More information about the gerrit-log mailing list