Change in osmo-bsc[master]: implement Channel Mode Modify to VAMOS mode

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun May 30 07:14:20 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24374 )

Change subject: implement Channel Mode Modify to VAMOS mode
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c@2174 
PS10, Line 2174: modify lchan
I would use modify-lchan as one word/token here, unless you are plannning to add other alternatiuves to lchan here.  I.e. "vamos modify ts" or the like.  Using extra words/tokens in the VTY language really only makes sense whenever there are multiple alternatives/choices to proceed.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24374
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibf53f4797d7491b17a33946fd7d920f038362b4c
Gerrit-Change-Number: 24374
Gerrit-PatchSet: 10
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 30 May 2021 07:14:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210530/f5f4fbb0/attachment.htm>


More information about the gerrit-log mailing list