This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24315 ) Change subject: mgcp_network: refactor MGCP_DUMMY_LOAD ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/24315/1/include/osmocom/mgcp/mgcp_network.h File include/osmocom/mgcp/mgcp_network.h: https://gerrit.osmocom.org/c/osmo-mgw/+/24315/1/include/osmocom/mgcp/mgcp_network.h@10 PS1, Line 10: a an > an Done https://gerrit.osmocom.org/c/osmo-mgw/+/24315/1/include/osmocom/mgcp/mgcp_network.h@18 PS1, Line 18: memcmp > Ack The dummy payload may be one byte but technically it is an array with only one element. That is why memcmp() is used. I have now changed the macro a bit. If we only have one byte rtp_dummy_payload it will directly compare the first byte. (I also added a unit-test so that we can be sure the macro still works now) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24315 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I21d96cefeeb647958bfa1e22a0ea030884746fad Gerrit-Change-Number: 24315 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Thu, 27 May 2021 13:12:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210527/22962f66/attachment.htm>