Change in osmo-bsc[master]: allow explixit TSC Set and TSC on chan activ / modif / assignment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu May 27 10:43:56 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24369 )

Change subject: allow explixit TSC Set and TSC on chan activ / modif / assignment
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24369/7/src/osmo-bsc/gsm_04_08_rr.c 
File src/osmo-bsc/gsm_04_08_rr.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24369/7/src/osmo-bsc/gsm_04_08_rr.c@694 
PS7, Line 694: 	tsc = (lchan->modify.info.tsc >= 0) ? lchan->modify.info.tsc : gsm_ts_tsc(lchan->ts); /* FIXME */
why this FIXME here?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24369
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic665125255d7354f5499d10dda1dd866ab243d24
Gerrit-Change-Number: 24369
Gerrit-PatchSet: 7
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 27 May 2021 10:43:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210527/e06e0f6f/attachment.htm>


More information about the gerrit-log mailing list