Change in osmo-bts[master]: Fix regression in 'bts: Clean up TS selection in sign_link_up'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed May 26 18:15:08 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24418 )

Change subject: Fix regression in 'bts: Clean up TS selection in sign_link_up'
......................................................................

Fix regression in 'bts: Clean up TS selection in sign_link_up'

Fixes: 518ada9414755ab859e0139289090a1ef7ba9be3
Change-Id: I63af96235eb6e0a7334936f65e1f44d4422198a5
---
M src/common/abis.c
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Hoernchen: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/src/common/abis.c b/src/common/abis.c
index 55962bd..ba3169a 100644
--- a/src/common/abis.c
+++ b/src/common/abis.c
@@ -118,6 +118,8 @@
 		return g_bts->oml_link;
 
 	case E1INP_SIGN_RSL:
+		/* fall through to default to catch TRXn having type = E1INP_SIGN_RSL + n  */
+	default:
 		trx_nr = type - E1INP_SIGN_RSL;
 		sign_ts = e1inp_line_ipa_rsl_ts(line, trx_nr);
 		LOGP(DABIS, LOGL_INFO, "RSL Signalling link for TRX%d up\n",
@@ -133,10 +135,6 @@
 						       trx, trx->rsl_tei, 0);
 		trx_link_estab(trx);
 		return trx->rsl_link;
-
-	default:
-		LOGP(DABIS, LOGL_ERROR, "Unknwon Signalling link up %d\n", (int)type);
-		return NULL;
 	}
 	return NULL;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24418
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I63af96235eb6e0a7334936f65e1f44d4422198a5
Gerrit-Change-Number: 24418
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210526/4e833c9a/attachment.htm>


More information about the gerrit-log mailing list