Change in osmo-ttcn3-hacks[master]: add bsc/BSC_Tests_VAMOS.ttcn

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed May 26 14:12:26 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411 )

Change subject: add bsc/BSC_Tests_VAMOS.ttcn
......................................................................


Patch Set 1: Code-Review-2

(2 comments)

This change introduces a lot of duplicated records/functions. You can avoid this using the 'friend'-imports, see ETSI ES 201 873-1, section 8.2.4 "Definition of friend modules". We already use this feature a lot in BTS_Tests[SMSCB,OML,perf].ttcn.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/1/bsc/BSC_Tests_VAMOS.ttcn 
File bsc/BSC_Tests_VAMOS.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/1/bsc/BSC_Tests_VAMOS.ttcn@94 
PS1, Line 94: SystemInformationConfig
This record can be imported from BSC_Tests (check 'friend' keyword), no need to duplicate it here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/1/bsc/BSC_Tests_VAMOS.ttcn@109 
PS1, Line 109: SystemInformationConfig_omit
Same here and down below. Maintaining copies of the same records/functions is going to be painful, so let's avoid it as much as possible.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2c504099163a30ea102cbd26d3615ca2e5ce1e64
Gerrit-Change-Number: 24411
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 26 May 2021 14:12:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210526/bddec057/attachment.htm>


More information about the gerrit-log mailing list