This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24388 ) Change subject: [VAMOS] osmo-bts-trx: properly handle per-timeslot TSC values ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/24388/3/src/osmo-bts-trx/l1_if.h File src/osmo-bts-trx/l1_if.h: https://gerrit.osmocom.org/c/osmo-bts/+/24388/3/src/osmo-bts-trx/l1_if.h@108 PS3, Line 108: bool setslot_valid[TRX_NR_TS]; > Why not merging too the valid and sent into the new struct array you created? Feels like you went ha […] Just wanted to keep it consistent with the other fields above, but I am also fine with merging it into the new structure array. https://gerrit.osmocom.org/c/osmo-bts/+/24388/3/src/osmo-bts-trx/trx_provision_fsm.c File src/osmo-bts-trx/trx_provision_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/24388/3/src/osmo-bts-trx/trx_provision_fsm.c@521 PS3, Line 521: trx_if_cmd_setslot(l1h, ts_data->tn, l1if_setslot_cb); > shouldn't you send it only if it didn't change? I could introduce additional checks for the TSC fields too, but does it really hurt if we sent it with the same parameters as before? So far this event is generated on receipt of the NM_MT_SET_CHAN_ATTR message, which is usually sent once for each timeslot during the OML bootstrapping. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idc5796151e3e83f42d60c2d4cb7c35890d76a7f5 Gerrit-Change-Number: 24388 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 25 May 2021 21:02:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210525/cf02d3ed/attachment.htm>