This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24394 ) Change subject: cosmetic loop simplification in gsm48_multirate_config() ...................................................................... cosmetic loop simplification in gsm48_multirate_config() Change-Id: I52424ad6a0bf499fe040cf0a1de00e636a0a40fe --- M src/osmo-bsc/gsm_04_08_rr.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/24394/1 diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c index 4eb6be1..9dc33af 100644 --- a/src/osmo-bsc/gsm_04_08_rr.c +++ b/src/osmo-bsc/gsm_04_08_rr.c @@ -417,13 +417,13 @@ uint8_t *data; /* Check if modes for consistency (order and duplicates) */ - for (i = 0; i < num_modes; i++) { - if (i > 0 && modes[i - 1].mode > modes[i].mode) { + for (i = 1; i < num_modes; i++) { + if (modes[i - 1].mode > modes[i].mode) { LOGP(DRR, LOGL_ERROR, "BUG: Multirate codec with inconsistent config (mode order).\n"); return -EINVAL; } - if (i > 0 && modes[i - 1].mode == modes[i].mode) { + if (modes[i - 1].mode == modes[i].mode) { LOGP(DRR, LOGL_ERROR, "BUG: Multirate codec with inconsistent config (duplicate modes).\n"); return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I52424ad6a0bf499fe040cf0a1de00e636a0a40fe Gerrit-Change-Number: 24394 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210525/f7aa3118/attachment.htm>