Change in osmo-bsc[master]: AMR config cleanup step 3: generate AMR LV on msg composition

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24358 )

Change subject: AMR config cleanup step 3: generate AMR LV on msg composition
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24358/2/src/osmo-bsc/gsm_04_08_rr.c 
File src/osmo-bsc/gsm_04_08_rr.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24358/2/src/osmo-bsc/gsm_04_08_rr.c@420 
PS2, Line 420: 	for (i = 1; i < num_modes; i++) {
this would ideally be a seprate commit


https://gerrit.osmocom.org/c/osmo-bsc/+/24358/2/src/osmo-bsc/gsm_04_08_rr.c@514 
PS2, Line 514: 	data[0] |= (modes_selected[1]->hysteresis & 0x0f) << 2;
You know you can do "data[0] = x | y;" right? ;)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24358
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie57f9d0e3912632903d9740291225bfd1634ed47
Gerrit-Change-Number: 24358
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 25 May 2021 10:32:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210525/cfb06307/attachment.htm>