This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24342 ) Change subject: contrib: Add sim-rest-{server,client}.py ...................................................................... Patch Set 3: Code-Review+2 (4 comments) https://gerrit.osmocom.org/c/pysim/+/24342/2/contrib/sim-rest-client.py File contrib/sim-rest-client.py: https://gerrit.osmocom.org/c/pysim/+/24342/2/contrib/sim-rest-client.py@39 PS2, Line 39: x2, x3 = struct.unpack('>IH', x) > I guess you could do this without using struct at all: […] tested, changed in next version. https://gerrit.osmocom.org/c/pysim/+/24342/2/contrib/sim-rest-client.py@46 PS2, Line 46: return struct.pack('>IH', x2, x3) > Also here: […] tested, changed in next version. https://gerrit.osmocom.org/c/pysim/+/24342/2/contrib/sim-rest-client.py@48 PS2, Line 48: dict > If all values in this dict() are bytes, then: […] Ack https://gerrit.osmocom.org/c/pysim/+/24342/2/contrib/sim-rest-client.py@61 PS2, Line 61: def milenage_auts(opc:bytes, k:bytes, rand:bytes, auts:bytes): > I would raise a RuntimeError directly from here, or alternatively: […] Ack -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I738ca3109ab038d4f5595cc1dab6a49087df5886 Gerrit-Change-Number: 24342 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Tue, 25 May 2021 07:44:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210525/d9c50154/attachment.htm>