This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24327 ) Change subject: [VAMOS] osmo-bts-trx: rework handling of Training Sequence ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/24327/1/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/24327/1/src/common/l1sap.c@1991 PS1, Line 1991: lchan->tsc_set = (cd->chan_nr & 0x80) ? 1 : 0; > is tsc_set really a number indexing the selected set? or set as in set(unset and hence a boolean? TS 45.002 defines 4 orthogonal TSC sets (8 sequences in each), and 'tsc_set' here is the number of a set. https://gerrit.osmocom.org/c/osmo-bts/+/24327/1/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/24327/1/src/common/scheduler.c@1221 PS1, Line 1221: if (lchan != NULL) { > why not reusing the already existing check below if (lchan != NULL) ? This function is called lots o […] Because func() needs to know it in advance. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3744bc308b99ef941e6e9d139444e414abebc14b Gerrit-Change-Number: 24327 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 24 May 2021 23:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210524/7b12a14d/attachment.htm>