Change in libosmocore[master]: kdf: add key derivation functions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun May 23 13:16:59 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24291 )

Change subject: kdf: add key derivation functions
......................................................................


Patch Set 7: Code-Review-1

(4 comments)

> Patch Set 7:

> I'm not aware of any test vectors, so it's a bit hard to test them against a known good result.

usually the relevant 3GPP specs have some test vectors in an annex.  So they skipped that here?

https://gerrit.osmocom.org/c/libosmocore/+/24291/7/src/gsm/kdf.c 
File src/gsm/kdf.c:

https://gerrit.osmocom.org/c/libosmocore/+/24291/7/src/gsm/kdf.c@93 
PS7, Line 93:     s[0] = 0x32; // yeah, really just one FC byte..
4-space indent is not tab-indent and hence not our coding style.


https://gerrit.osmocom.org/c/libosmocore/+/24291/7/src/gsm/kdf/common.h 
File src/gsm/kdf/common.h:

https://gerrit.osmocom.org/c/libosmocore/+/24291/7/src/gsm/kdf/common.h@7 
PS7, Line 7:  
I'm not particularly excited about importing code under other licenses to libosmocore.  Makes license compliance very difficult for downstream users.  And if we absolutely have to do it, the debian/copyright must be updated accordingly.

IMHO the exsting functions about crypto we imported from hostapd was dueal-licensed BSD / GPL, so it was easy to choose the GPL.


https://gerrit.osmocom.org/c/libosmocore/+/24291/7/src/gsm/kdf/common.h@60 
PS7, Line 60: typedef uint64_t u64;
looking at the contents of this file, I would argue it is not even copyrightable and hence no license applies.


https://gerrit.osmocom.org/c/libosmocore/+/24291/7/src/gsm/kdf/crypto.h 
File src/gsm/kdf/crypto.h:

https://gerrit.osmocom.org/c/libosmocore/+/24291/7/src/gsm/kdf/crypto.h@5 
PS7, Line 5:  * This software may be distributed under the terms of the BSD license.
but here we'd then have BSD-only code :/

as those are general-purpuse crypto routines, I would expect some [L]GPLv2 (or later) implementations out there that would ensure our users don't have to worry about yet another license in the osmocom code base.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24291
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibf2e49edada944d91ceba62bd0d6b6ce69261fcd
Gerrit-Change-Number: 24291
Gerrit-PatchSet: 7
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 23 May 2021 13:16:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210523/607a84f8/attachment.htm>


More information about the gerrit-log mailing list