Change in libosmocore[master]: gprs_ns2: sns: fix del bind()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24120 )

Change subject: gprs_ns2: sns: fix del bind()
......................................................................

gprs_ns2: sns: fix del bind()

When the bind to be removed is not the last entry, it would
remove the wrong SNS bind resulting in use-after-free memory.

Change-Id: I79062d404ebba9d5c8f7f209bebde146fa08c71f
---
M src/gb/gprs_ns2_sns.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  daniel: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index c6e80af..296a2e7 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -1995,6 +1995,7 @@
 		if (tmp->bind == bind) {
 			llist_del(&tmp->list);
 			found = true;
+			break;
 		}
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I79062d404ebba9d5c8f7f209bebde146fa08c71f
Gerrit-Change-Number: 24120
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210523/21c99a36/attachment.htm>