Change in osmo-sgsn[master]: add support for multiple encryption algorithms + a5/4

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun May 23 10:29:40 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/24304 )

Change subject: add support for multiple encryption algorithms + a5/4
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/2/src/sgsn/gprs_gmm.c 
File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/2/src/sgsn/gprs_gmm.c@452 
PS2, Line 452: >>=
I have to admit I don't think I've ever seen this construct before. At least I am not able to read this without thinking rather hard what is happening here... But maybe that's just me.


https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/2/src/sgsn/sgsn_vty.c 
File src/sgsn/sgsn_vty.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/2/src/sgsn/sgsn_vty.c@732 
PS2, Line 732: (GEA0-4) [GEA0-4] [GEA0-4] [GEA0-4] [GEA0-4]
I don't think this works as expected, does it? all-caps tokens in VTY parser syntax are typically "accept any string".  I would go for something that's in-line with e.g. osmo-bsc for A5:

"encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]"

Here the <> indicates that it's an integer range and the VTY parser will ensure you cannot enter anything else.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/24304
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie6700c4e9d2df1eb5fde1b971e287b62668cc2de
Gerrit-Change-Number: 24304
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 23 May 2021 10:29:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210523/ff07ec12/attachment.htm>


More information about the gerrit-log mailing list