Change in osmo-bts[master]: [VAMOS] struct gsm_lchan: store Training Sequence Code/Set

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24327 )

Change subject: [VAMOS] struct gsm_lchan: store Training Sequence Code/Set
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/24327/1/src/common/l1sap.c 
File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24327/1/src/common/l1sap.c@1991 
PS1, Line 1991: 		lchan->tsc_set = (cd->chan_nr & 0x80) ? 1 : 0;
is tsc_set really a number indexing the selected set? or set as in set(unset and hence a boolean?


https://gerrit.osmocom.org/c/osmo-bts/+/24327/1/src/common/scheduler.c 
File src/common/scheduler.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24327/1/src/common/scheduler.c@1221 
PS1, Line 1221: 	if (lchan != NULL) {
why not reusing the already existing check below if (lchan != NULL) ? This function is called lots of times.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24327
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3744bc308b99ef941e6e9d139444e414abebc14b
Gerrit-Change-Number: 24327
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 21 May 2021 16:01:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210521/19a762c4/attachment.htm>