Change in osmo-bts[master]: [VAMOS] osmo-bts-trx: implement and enable PDU batching for TRXDv2

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24324 )

Change subject: [VAMOS] osmo-bts-trx: implement and enable PDU batching for TRXDv2
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/24324/1/src/osmo-bts-trx/trx_if.c 
File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24324/1/src/osmo-bts-trx/trx_if.c@1086 
PS1, Line 1086: 	if (br == NULL) {
The code flow used here looks really complex and confusing with all the checkings and goto. Have a look at the following proposal:

if (br) {
...


https://gerrit.osmocom.org/c/osmo-bts/+/24324/1/src/osmo-bts-trx/trx_if.c@1133 
PS1, Line 1133: 	if (pdu_ver >= 2)
...
} else if (pdu_ver < 2 || pdu_num == 0) {
 return -ENOMSG;
} else {
  last_pdu[1] &= ~(1 << 7);
}



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24324
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I9b4cc8e10cd683b28d22e32890569484cd20372d
Gerrit-Change-Number: 24324
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 21 May 2021 15:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210521/8fe6d576/attachment.htm>