Change in osmo-gsm-tester[master]: ms-srs: change the cpu governor before launching the ms.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

srs_andre gerrit-no-reply at lists.osmocom.org
Thu May 20 19:12:43 UTC 2021


srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24270 )

Change subject: ms-srs: change the cpu governor before launching the ms.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > What's the purpose of adding this complexity to OGT code? Why not simply do this kind of stuff on the script launching osmo-gsm-tester, or even permanentely set the governor in the host?
> > I'm not really liking this idea tbh.
> 
> Hi Pau,
> 
> I needed to set the cpu governor to performance during the test execution to get the best of the device, but I don't want the device to be always in performance mode, as it is a waste of resources. 
> I did it in the srs-ue as it's the class that has all the knowledge about what has to be done and in what order.
> For adding this feature in the script that launches osmo-gsm-tester, it will need to parse the information of the test to retrieve the resources and decide which one should change the governor, but it is already done by osmo-gsm-tester.
> As I said before, for the second option, I don't want the device to be always in performance mode, just only the test, so the device can be cooler and with less consumption.
> Do you have any other suggestion when I can place this funcionality.
> 
> Thank you very much for your comments, they're giving me a wider vision of how osmo-gsm-tester works

@pespin: we need some sort of way to execute custom scripts on a resource controlled by OGT. See other patch for that feature. This is mainly to configure external HW. In theory we could also call the CPU govenor script from that "pre-test" script. Adding a stand-alone govenor script, however, felt general-purpose enought so we went for this. approach.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24270
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I86ec4fbba8a965e60103b30e2aa60cd2c3f348c9
Gerrit-Change-Number: 24270
Gerrit-PatchSet: 1
Gerrit-Owner: alealcon <alejandro.leal at srs.io>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 20 May 2021 19:12:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210520/e7f31765/attachment.htm>


More information about the gerrit-log mailing list