This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/24320 ) Change subject: ipaccess: do not block ipaccess_line_update on failure ...................................................................... ipaccess: do not block ipaccess_line_update on failure The function ipaccess_line_update (called when the API user calls e1inp_line_update and the line is of type ipaccess) internally sets the line_already_initialized regardless whether the initalization is successful or not. This also means that if the initalization fails the API user is unable to retry the initalition with corrected line options. Change-Id: I90d330e2864f85b964628502afdb0c38eb54f15d Related: SYS#4971 --- M src/input/ipaccess.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/20/24320/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index e876790..a584e0d 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -1025,8 +1025,6 @@ if (il->line_already_initialized) return 0; - il->line_already_initialized = true; - switch(line->ops->cfg.ipa.role) { case E1INP_LINE_R_BSC: { struct ipa_server_link *oml_link, *rsl_link; @@ -1112,6 +1110,8 @@ default: break; } + + il->line_already_initialized = true; return ret; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/24320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I90d330e2864f85b964628502afdb0c38eb54f15d Gerrit-Change-Number: 24320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210520/e953f886/attachment.htm>