Change in osmo-gsm-tester[master]: srs-ms: allows to run given scripts before the execution of the UE.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu May 20 17:51:14 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24277 )

Change subject: srs-ms: allows to run given scripts before the execution of the UE.
......................................................................


Patch Set 1:

Hi,

If you "don't want to give the ue the knowledge of what it is executing", then to me it looks like it's not the proper place to do it, since that's the object class which controls and manages one UE. Playing with lots of system-wide options there doesn't look correct.

All system-wide configuration should in general be done outside of OGT, since the idea is that you may end up running whatever else in the same node at the same time (be it from same OGT instance or another one).

I have the feeling you are trying to hook tons of generic features turning OGT into a full-blown network orchestrator, and hence you are adding a lot of complexity which imho shouldn't be here, since the environment is already complex enough. I don't want to end up with dozens of shell scripts to be moved and executed here and there if it can be avoided. And I'm pretty sure in the long run you don't want to end up there either.

I'm not against adding stuff like that if really necessary, but I'd really like to discuss them one by one and see how it can be done in a good way. What exactly do you need to check and how? What's the exact problem and what do you need to do to solve it? Feel free to contact me over email or jabber if you want to discuss this further. Also feel free to contact me if you plan to add new features, I may be able to give you some hints to drive you into a good direction from start and speed up your development.

For instance, in the case of powercycling the uhd device if it's not working, there's 3 ways I can quickly think could work:
[1] In the jenkins job / script calling osmo-gsm-tester, connect to the remote host where you plan to run stuff (if it's a static setup) and make sure it's reset.
[2] Have a systemd service running in each of those nodes which for instance is executed every 5 min and checks if no ssh user is in, then reset the device if needed
[2] If there's a specific command you want to call in order to clean up something, add that explicitly to OGT code, instead of generic scripts. You can even generate and scp bash scripts on the fly from within OGT. You can define new tags on run_nodes or srsue resources if needed too in order to mark specific actions.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24277
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I718e686b5844f2f07eda820914678052f1008182
Gerrit-Change-Number: 24277
Gerrit-PatchSet: 1
Gerrit-Owner: alealcon <alejandro.leal at srs.io>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 20 May 2021 17:51:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210520/f12ef516/attachment.htm>


More information about the gerrit-log mailing list