Change in osmo-gsm-tester[master]: iperf: adds the option to define the packet length for udp.

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273 )

Change subject: iperf: adds the option to define the packet length for udp.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273/1/src/osmo_gsm_tester/obj/iperf3.py 
File src/osmo_gsm_tester/obj/iperf3.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273/1/src/osmo_gsm_tester/obj/iperf3.py@276 
PS1, Line 276:             buffer_length = str(values.get('length'))
what if length is not defined? Probably safer to have something like this:

 if values.get('length'):
   buffer_length = str(values.get('length'))
   popen_args += ('-l', buffer_length)


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273/1/sysmocom/scenarios/cfg-iperf3-length%40.conf 
File sysmocom/scenarios/cfg-iperf3-length at .conf:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273/1/sysmocom/scenarios/cfg-iperf3-length%40.conf@3 
PS1, Line 3:     length: ${param1} 
extra trailing whitespace



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ic886faa82b7cb25f2bce685eb80910623e4ff686
Gerrit-Change-Number: 24273
Gerrit-PatchSet: 1
Gerrit-Owner: Alejandro Leal <alejandro.leal at srs.io>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 20 May 2021 12:28:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210520/be15f97c/attachment.htm>