Change in osmo-bsc[master]: handover_test: ack release only when lchan is still waiting

[neels]

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24303 )


Change subject: handover_test: ack release only when lchan is still waiting
......................................................................

handover_test: ack release only when lchan is still waiting

Change-Id: I4c7596df06d7c211adcfcd110a1984903a0820e1
---
M tests/handover/handover_test.c
1 file changed, 8 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/03/24303/1

diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c
index d2b1757..8e23a4f 100644
--- a/tests/handover/handover_test.c
+++ b/tests/handover/handover_test.c
@@ -439,12 +439,14 @@
 
 static void lchan_release_ack(struct gsm_lchan *lchan)
 {
-	if (lchan->fi && lchan->fi->state == LCHAN_ST_WAIT_BEFORE_RF_RELEASE) {
-		/* don't wait before release */
-		osmo_fsm_inst_state_chg(lchan->fi, LCHAN_ST_WAIT_RF_RELEASE_ACK, 0, 0);
-		/* ack the release */
-		osmo_fsm_inst_dispatch(lchan->fi, LCHAN_EV_RSL_RF_CHAN_REL_ACK, 0);
-	}
+	if (!lchan->fi || lchan->fi->state != LCHAN_ST_WAIT_BEFORE_RF_RELEASE)
+		return;
+	/* don't wait before release */
+	osmo_fsm_inst_state_chg(lchan->fi, LCHAN_ST_WAIT_RF_RELEASE_ACK, 0, 0);
+	if (lchan->fi->state == LCHAN_ST_UNUSED)
+		return;
+	/* ack the release */
+	osmo_fsm_inst_dispatch(lchan->fi, LCHAN_EV_RSL_RF_CHAN_REL_ACK, 0);
 }
 
 static void lchan_clear(struct gsm_lchan *lchan)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24303
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4c7596df06d7c211adcfcd110a1984903a0820e1
Gerrit-Change-Number: 24303
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210519/78bf73f8/attachment.htm>