Change in osmo-bts[master]: common: phy_links_open(): warn about dangling PHY instances

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/24288 )


Change subject: common: phy_links_open(): warn about dangling PHY instances
......................................................................

common: phy_links_open(): warn about dangling PHY instances

Change-Id: I8d84bf7a00da6b985cb3dc314e86cacac8d4f48c
---
M src/common/phy_link.c
1 file changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/24288/1

diff --git a/src/common/phy_link.c b/src/common/phy_link.c
index 93c6f2c..7743c22 100644
--- a/src/common/phy_link.c
+++ b/src/common/phy_link.c
@@ -154,11 +154,20 @@
 
 int phy_links_open(void)
 {
+	const struct phy_instance *pinst;
 	struct phy_link *plink;
 
 	llist_for_each_entry(plink, &g_phy_links, list) {
 		int rc;
 
+		/* Warn about dangling PHY instances */
+		llist_for_each_entry(pinst, &plink->instances, list) {
+			if (pinst->trx != NULL)
+				continue;
+			LOGPPHI(pinst, DL1C, LOGL_NOTICE, "This PHY instance is not associated "
+				"with a TRX instance, check the configuration file!\n");
+		}
+
 		rc = bts_model_phy_link_open(plink);
 		if (rc < 0)
 			return rc;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24288
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8d84bf7a00da6b985cb3dc314e86cacac8d4f48c
Gerrit-Change-Number: 24288
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210519/396103af/attachment.htm>