Change in osmo-pcu[master]: bts: Use ms_store when calculating set of target PDCHs for Pkt Paging...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed May 19 10:50:11 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/24225 )

Change subject: bts: Use ms_store when calculating set of target PDCHs for Pkt Paging Request
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/24225/1/src/bts.cpp 
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/24225/1/src/bts.cpp@402 
PS1, Line 402: llist_for_each
> Why now llist_for_each_entry()?
I have seen ASAN triggering false positives (runtime errors) with those in C++ code/files in this same project, so I'm trying to avoid more of those  here.


https://gerrit.osmocom.org/c/osmo-pcu/+/24225/1/src/bts.cpp@406 
PS1, Line 406: tbfs[l]
> For a second I thought it's tbfs[1] but it's actually tbfs[l].
I didn't choose the variable name, it was already there. I'm not even sure what "l" is supposed to refer to here. "l" from "list"?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24225
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I671e531921bbea2f5cc0f2bfcb8a39ea5c6673b8
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 19 May 2021 10:50:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210519/8e3b98f3/attachment.htm>


More information about the gerrit-log mailing list