Change in osmo-sgsn[master]: Support forwarding RIM messages over GTPCv1 EUTRAN<->GERAN

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/24164 )

Change subject: Support forwarding RIM messages over GTPCv1 EUTRAN<->GERAN
......................................................................


Patch Set 8:

(7 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/24164/8//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24164/8//COMMIT_MSG@9 
PS8, Line 9: SGSn
(SGSN)


https://gerrit.osmocom.org/c/osmo-sgsn/+/24164/8//COMMIT_MSG@10 
PS8, Line 10: Informarion
(Information)


https://gerrit.osmocom.org/c/osmo-sgsn/+/24164/8/doc/manuals/chapters/configuration.adoc 
File doc/manuals/chapters/configuration.adoc:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24164/8/doc/manuals/chapters/configuration.adoc@74 
PS8, Line 74: contains too
"also contains"


https://gerrit.osmocom.org/c/osmo-sgsn/+/24164/8/doc/manuals/chapters/configuration.adoc@98 
PS8, Line 98: It allows specifi
Sentence cut off?


https://gerrit.osmocom.org/c/osmo-sgsn/+/24164/8/src/sgsn/gtp_mme.c 
File src/sgsn/gtp_mme.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24164/8/src/sgsn/gtp_mme.c@63 
PS8, Line 63: 	
(indentation)


https://gerrit.osmocom.org/c/osmo-sgsn/+/24164/8/src/sgsn/sgsn_libgtp.c 
File src/sgsn/sgsn_libgtp.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24164/8/src/sgsn/sgsn_libgtp.c@720 
PS8, Line 720: 	if (gtpie_gettlv(ie, GTPIE_RIM_RA_DISCR, 0, &len, &discr, 1) || len != 1) {
Why are these checks commented out?


https://gerrit.osmocom.org/c/osmo-sgsn/+/24164/8/src/sgsn/sgsn_rim.c 
File src/sgsn/sgsn_rim.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24164/8/src/sgsn/sgsn_rim.c@49 
PS8, Line 49: 	/* TODO: find mme from VTY routing rules */
looks like the code above implements this TODO



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/24164
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I396450b8d8b66595dab8ff7bf41cbf964bb40d93
Gerrit-Change-Number: 24164
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 19 May 2021 07:16:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210519/4fb60e67/attachment.htm>